The Battle of Dien Bien Phu was fought from March to May 1954 between the French Union forces defending the valley of Dien Bien Phu and the Viet Minh under General Vo Nguyen Giap. The French aimed to force a decisive engagement, but the Viet Minh surrounded the base, cut its supply lines and overran the strongpoints after weeks of artillery bombardment and trench warfare. On 7 May 1954 the garrison surrendered; the defeat ended French political control in Indochina and led to the Geneva Accords, which partitioned Vietnam at the 17th parallel and set elections that were never held. The victory became a landmark of anti-colonial warfare and shaped the later Vietnamese and Southeast Asian order.